Skip to content

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Oct 8, 2014

  • Fails the build on test failure
  • Splits out our custom Grunt tasks
  • Update the relative require paths after moving the tasks from the Gruntfile

TODO:

  • Fix Travis 0.8 NPM related failure. Will try updating to the latest 1.4.x release
  • Fix or remove the currently failing @viewport test

- Fails the build on test failure
- Splits out our custom Grunt tasks
- Update the relative require paths after moving the tasks from the
Gruntfile
@nschonni nschonni added this to the 0.11.0 milestone Oct 8, 2014
@nschonni
Copy link
Member Author

nschonni commented Oct 8, 2014

@XhmikosR the test suite is now failing correctly. Just need to fix the remaining failure.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 8, 2014

@nschonni: Cool, good to see you back :)

But why do you even support node 0.8?

@nschonni
Copy link
Member Author

nschonni commented Oct 9, 2014

@XhmikosR we can look at dropping 0.8 later. I just want to focus on getting this back to green, and then cut the long delayed release.


Notes for failing test:

  • Stringified test failure results {"messages":[{"type":"error","message":"Fatal error, cannot continue: Cannot call method 'push' of undefined","rule":{}}],"stats":[],"ruleset":{"order-alphabetical":1,"errors":2}}
  • Believe it traces back to parserlib in the addListener function. Need to verify that when the @viewport was included, it was correctly wired.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 9, 2014

@nschonni: cool, awesome! I hope you fix the failures so that we can have a new release soon to get things going again.

BTW, I think the npm fix should be in master and not in this PR. Then I can rebase #512 and we can merge it. But keep in mind, whoever has node.js 0.8 won't be able to install the deps so it's really useless to do the workaround... unless they have an updated npm version installed too.

Viewport was completely missing, but the others were also not reporting
at the end of the rule scope
Was previously only picking up the first fail, then the
`grunt.fail.warn` would terminate additional logging
nschonni added a commit that referenced this pull request Feb 28, 2015
Testing: Update the YUI Test harness for Grunt
@nschonni nschonni merged commit 5c473a6 into master Feb 28, 2015
@nschonni nschonni deleted the fix-yuitest-reporter branch February 28, 2015 17:53
@nschonni nschonni mentioned this pull request Feb 28, 2015
@XhmikosR XhmikosR modified the milestones: 0.11.0, 1.0.0 Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants